Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move man generation to hack folder #3464

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Move man generation to hack folder #3464

merged 1 commit into from
Jan 3, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 31, 2019

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Dec 31, 2019 •
edited
Loading

Codecov Report

Merging #3464 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️
cmd/skaffold/skaffold.go 0% <0%> (ø) ⬆️
pkg/skaffold/util/tar.go 57.47% <0%> (+4.59%) ⬆️

@balopat balopat merged commit 6296ed4 into GoogleContainerTools:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot